Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misalignment of documentation in BahdanauAttention #28267

Merged

Conversation

yongtang
Copy link
Member

This fix fixes the misalignment of documentation in BahdanauAttention,
as was specified in #28054. The issue seems to be that (optional)
should be placed after the : so that memory_sequence_length
could be identified as an arg.

This fix fixes #28054.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

This fix fixes the misalignment of documentation in BahdanauAttention,
as was specified in 28054. The issue seems to be that ` (optional)`
should be placed after the `:` so that memory_sequence_length
could be identified as an arg.

This fix fixes 28054.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Apr 29, 2019
@yongtang yongtang requested a review from lamberta April 29, 2019 18:30
Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 29, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 29, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 29, 2019
@rthadur rthadur moved this from Assigned Reviewer to Approved by Reviewer in PR Queue Apr 29, 2019
@rthadur rthadur self-assigned this Apr 29, 2019
Copy link
Contributor

@dynamicwebpaige dynamicwebpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix. 😊

@tensorflow-bot tensorflow-bot bot added the kokoro:force-run Tests on submitted change label Apr 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 30, 2019
@tensorflow-copybara tensorflow-copybara merged commit 373ab6a into tensorflow:master Apr 30, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 30, 2019
pull bot pushed a commit to testkevinbonz/tensorflow that referenced this pull request Apr 30, 2019
@yongtang yongtang deleted the 28054-BahdanauAttention branch April 30, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

misalignment in BahdanauAttention documentation
7 participants